[Lens] Enable report sharing #153429

dej611 · 2023-03-22T11:00:59Z

Summary

This PR introduces the PNG/PDF reporting feature within Lens editor.
Note each reporting tasks is generating a shortURL SO in addition of the reporting job SO. There's a reusing mechanism but it applies only to the same config within the same session.

Reporting page:

Note: at the moment the reporting name follows the CSV naming convention of unsaved for unsaved Lens visualizations. The legacy Agg-based editor uses instead a namming pattern as follow: Visualization <timestamp>.png.

Final results:

Chart type	PNG result
Stacked bar chart
Vertical bar chart
Horizontal stacked bar chart
Horizontal bar chart
Datatable
Horizontal gauge
Vertical gauge
Legacy metric
Metric
Metric with breakdown
Area chart
Line chart
Bar chart with annotation + reference lines
Heatmap
Donut chart
Pie chart
Treemap
Mosaic
Waffle
Region Map

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

dej611 · 2023-03-22T14:00:08Z

...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx

@@ -624,6 +624,12 @@ export const InnerWorkspacePanel = React.memo(function InnerWorkspacePanel({
  );
 });

+function dispatchRenderComplete(node: HTMLDivElement | null) {


There's also a RenderCompleteDispatcher class, but for just few lines I thought to inline it here

cc @vadimkibana

I think it's good to use your inline dispatcher.

dej611 · 2023-03-22T14:21:36Z

x-pack/plugins/screenshotting/server/layouts/preserve_layout.css

@@ -7,6 +7,11 @@
  display: none !important;
 }

+/* some elements needs to be stretched to be shared */
+.stretch-for-sharing {
+  margin: 0px;


I have not found any other solution here to remove the bottom margin in Lens' workspace, used to space the suggestion panel from the chart one.

…e/130438

elasticmachine · 2023-03-23T16:32:02Z

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

stratoula

This looks awesome Marco, def one of my favorite enhancements for 8.8. PNGs are created without stretching but I see some stretching on pdfs

I tested the agg based and they also have the same problem so I think it is fine for now.

Question: When I share an unsaved agg based visualization the report has the title Visualization[DATE]. Can we do the same for Lens? Because now all of them have the unsaved title and can be difficult for someone to identify them (the date can always help)

Exporting a metric with a scrollbar is generating a png that misses the last row. Can we fix it? (same happens with a bar with a very long legend)

stratoula · 2023-03-24T08:32:21Z

x-pack/test/functional/apps/lens/group3/lens_reporting.ts

@dej611 can we run a test runner 50 times to ensure that the tests added are not flaky?

Sure 100 runs all passing ✅ : https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2034

stratoula · 2023-03-24T08:57:03Z

I also see this error on the kibana server every time I export a lens viz

dej611 · 2023-03-24T09:08:24Z

I also see this error on the kibana server every time I export a lens viz

That is not dependent on this reporting PR but it happens also in main.
To reproduce:

get a snapshot URL from the share action
paste the URL in a browser and open the devtools console

I think it can be addressed as separate issue.

Exporting a metric with a scrollbar is generating a png that misses the last row. Can we fix it? (same happens with a bar with a very long legend)

I will look into this but that is happening also to datatable and with the legacy agg-based datatables as well: for scrollable visualizations it seems the reporting task is not taking the full height in consideration.

Question: When I share an unsaved agg based visualization the report has the title Visualization[DATE]. Can we do the same for Lens? Because now all of them have the unsaved title and can be difficult for someone to identify them (the date can always help)

Sure, it is possible. Right now it matches the CSV naming behaviour but will look into it 👍

stratoula · 2023-03-24T09:25:09Z

got it Marco thanx, I am fine with the first 1. About the second I am also fine if it is something that needs an investigation and is not an easy fix. Thanx for looking into the 3rd one!

…e/130438

dej611 · 2023-03-24T14:25:54Z

Updated the naming convention. Note that unfortunately this applies also to the CSV exporting.

…e/130438

dej611 · 2023-03-31T10:58:08Z

After #153492 the reporting feature worked also for RegionMap when embedded in dashboard, but not when in Lens Editor.
e8c4e5f fixed this issue, which was due to an initial error on bootstrap, now prevented with the correct check.

tsullivan

This is looking great, and it's so close! I still see one issue where the report doesn't contain the latest state of the work in the browser.

Steps to reproduce:

Install eCommerce Sample Data
Open the Dashboard, click Edit
Edit the "Breakdown by Category" visualization
Save the visualization to the library (uncheck Update panel on Dashboard)
Now make a change to the visualization. Example: change the breakdown field to customer first name.
Without saving the visualization, make a PNG report
The report shows the breakdown by category still - not the unsaved changes.

Users should be able to make a report that includes some ad-hoc (unsaved) changes. It's not uncommon to see users with reporting privileges and read-only privileges to visualizations. Therefore, when a report is made based on a saved object with some unsaved changes, the report should show what the browser shows: a merge of the saved state and the ad-hoc changes.

dej611 · 2023-04-04T08:31:16Z

This is looking great, and it's so close! I still see one issue where the report doesn't contain the latest state of the work in the browser.

Steps to reproduce:

Install eCommerce Sample Data

Open the Dashboard, click Edit

Edit the "Breakdown by Category" visualization

Save the visualization to the library (uncheck Update panel on Dashboard)

Now make a change to the visualization. Example: change the breakdown field to customer first name.

Without saving the visualization, make a PNG report

The report shows the breakdown by category still - not the unsaved changes.

Users should be able to make a report that includes some ad-hoc (unsaved) changes. It's not uncommon to see users with reporting privileges and read-only privileges to visualizations. Therefore, when a report is made based on a saved object with some unsaved changes, the report should show what the browser shows: a merge of the saved state and the ad-hoc changes.

Fixed in fe0d606 for both v1 and v2.
The only problem now is that in a dirty state the URL is too long and cannot be exported via CURL: Lens uses the shortURL service because its locator URL is too long, but reporting v2 is ignoring such parameter. Maybe it is possible to enhance it to support the given URL like v1 or use the shortURL service (if available) for such case?

tsullivan

LGTM

Great work! Thanks for bearing with me through the requirements about optimizing the locator params.

tsullivan · 2023-04-06T19:02:18Z

The only problem now is that in a dirty state the URL is too long and cannot be exported via CURL: Lens uses the shortURL service because its locator URL is too long, but reporting v2 is ignoring such parameter. Maybe it is possible to enhance it to support the given URL like v1 or use the shortURL service (if available) for such case?

Let's not worry greatly that a POST URL can't be copied from Lens when the visualization is in a dirty state. Advanced users will be able to modify the POST URL to add filters if needed.

Sorry that the integration is in a confusing state, since the share panel options accept a URL but that URL is not used for Reporting. The V1 interface only exists from tech debt, since putting a URL in the job parameters doesn't serve a great purpose for the future plans of reporting.

tsullivan · 2023-04-06T20:18:59Z

x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

@@ -116,7 +118,7 @@ export const reportingScreenshotShareProvider = ({
    });

    const jobProviderOptions: JobParamsProviderOptions = {
-      shareableUrl,
+      shareableUrl: isDirty ? shareableUrl : shareableUrlForSavedObject ?? shareableUrl,


I've filed this issue to remove V1 code from reporting, which will make the shareableUrl field not part of JobParamsProviderOptions in the future: #154601

kibana-ci · 2023-04-10T12:21:50Z

💚 Build Succeeded

Buildkite Build
Commit: a414421

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lens`	1.3MB	1.3MB	+1.5KB
`reporting`	58.8KB	58.9KB	+169.0B
total			+1.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`lens`	34.3KB	34.3KB	+24.0B
`reporting`	42.5KB	42.6KB	+88.0B
total			+112.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	433	436	+3

Total ESLint disabled count

id	before	after	diff
`securitySolution`	513	516	+3

History

💛 Build #117592 was flaky fe0d606
💚 Build #117031 succeeded 39dcb2e
💛 Build #117006 was flaky f7b8943
💛 Build #116773 was flaky 719afe2
💚 Build #116735 succeeded 82c18f1
💔 Build #116538 failed a1b3006

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

## Summary Adds the 8.8 documentation for the following: - Enable report sharing: #153429 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/reporting-getting-started.html - Random sampling feature: #143221 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#improve-visualization-loading-time - Improve Ignore global filters UI: #154441 and #155280 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations --------- Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

## Summary Adds the 8.8 documentation for the following: - Enable report sharing: elastic#153429 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/reporting-getting-started.html - Random sampling feature: elastic#143221 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#improve-visualization-loading-time - Improve Ignore global filters UI: elastic#154441 and elastic#155280 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations --------- Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com> (cherry picked from commit 06a800f)

# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Adds 8.8 Viz docs (#157215)](#157215)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>

## Summary Adds the 8.8 documentation for the following: - Enable report sharing: elastic#153429 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/reporting-getting-started.html - Random sampling feature: elastic#143221 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#improve-visualization-loading-time - Improve Ignore global filters UI: elastic#154441 and elastic#155280 Docs preview: https://kibana_157215.docs-preview.app.elstc.co/guide/en/kibana/master/lens.html#add-annotations --------- Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>

…163873) ## Summary This PR fixes a bug mentioned in elastic/sdh-kibana#4016 from #153429 where users with custom roles should allow them the ability to generate reports (with `xpack.reporting.roles.enabled: false`) in Dashboard. This bug doesn't arise for users with all privileges. - set xpack.reporting.roles.enabled false in the kibana.yml - load sample data - create a custom role where the index (whatever sample data index you want) has the read and view_index_metadata privilege. - Add the Kibana privilege for all spaces Analytics > Dashboard > Generate PDF or PNG Reports and Download Csv reports from Saved Search panels. Create the global privilege and then the role. - Apply that role to a new user and log in using that user. ## Before You can see in the console that usesUiCapabilitie in register_pdf_png_reporting.tsx is true <img width="1458" alt="Screenshot 2023-08-14 at 12 34 38 PM" src="https://github.com/elastic/kibana/assets/20343860/f6b567fa-3fbd-4039-aa64-fd28bb4534fb"> ## After <img width="1343" alt="Screenshot 2023-08-14 at 2 18 30 PM" src="https://github.com/elastic/kibana/assets/20343860/1e4ade9e-332c-4431-954a-38e8a16d4131"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…lastic#163873) ## Summary This PR fixes a bug mentioned in elastic/sdh-kibana#4016 from elastic#153429 where users with custom roles should allow them the ability to generate reports (with `xpack.reporting.roles.enabled: false`) in Dashboard. This bug doesn't arise for users with all privileges. - set xpack.reporting.roles.enabled false in the kibana.yml - load sample data - create a custom role where the index (whatever sample data index you want) has the read and view_index_metadata privilege. - Add the Kibana privilege for all spaces Analytics > Dashboard > Generate PDF or PNG Reports and Download Csv reports from Saved Search panels. Create the global privilege and then the role. - Apply that role to a new user and log in using that user. ## Before You can see in the console that usesUiCapabilitie in register_pdf_png_reporting.tsx is true <img width="1458" alt="Screenshot 2023-08-14 at 12 34 38 PM" src="https://github.com/elastic/kibana/assets/20343860/f6b567fa-3fbd-4039-aa64-fd28bb4534fb"> ## After <img width="1343" alt="Screenshot 2023-08-14 at 2 18 30 PM" src="https://github.com/elastic/kibana/assets/20343860/1e4ade9e-332c-4431-954a-38e8a16d4131"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 54d11a9)

…ard (#163873) (#163972) # Backport This will backport the following commits from `main` to `8.9`: - [[Reporting] Allow custom roles to use image reporting in dashboard (#163873)](#163873)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Rachel Shen <rshen@elastic.co>

…lastic#163873) ## Summary This PR fixes a bug mentioned in elastic/sdh-kibana#4016 from elastic#153429 where users with custom roles should allow them the ability to generate reports (with `xpack.reporting.roles.enabled: false`) in Dashboard. This bug doesn't arise for users with all privileges. - set xpack.reporting.roles.enabled false in the kibana.yml - load sample data - create a custom role where the index (whatever sample data index you want) has the read and view_index_metadata privilege. - Add the Kibana privilege for all spaces Analytics > Dashboard > Generate PDF or PNG Reports and Download Csv reports from Saved Search panels. Create the global privilege and then the role. - Apply that role to a new user and log in using that user. ## Before You can see in the console that usesUiCapabilitie in register_pdf_png_reporting.tsx is true <img width="1458" alt="Screenshot 2023-08-14 at 12 34 38 PM" src="https://github.com/elastic/kibana/assets/20343860/f6b567fa-3fbd-4039-aa64-fd28bb4534fb"> ## After <img width="1343" alt="Screenshot 2023-08-14 at 2 18 30 PM" src="https://github.com/elastic/kibana/assets/20343860/1e4ade9e-332c-4431-954a-38e8a16d4131"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 54d11a9)

…lastic#163873) ## Summary This PR fixes a bug mentioned in elastic/sdh-kibana#4016 from elastic#153429 where users with custom roles should allow them the ability to generate reports (with `xpack.reporting.roles.enabled: false`) in Dashboard. This bug doesn't arise for users with all privileges. - set xpack.reporting.roles.enabled false in the kibana.yml - load sample data - create a custom role where the index (whatever sample data index you want) has the read and view_index_metadata privilege. - Add the Kibana privilege for all spaces Analytics > Dashboard > Generate PDF or PNG Reports and Download Csv reports from Saved Search panels. Create the global privilege and then the role. - Apply that role to a new user and log in using that user. ## Before You can see in the console that usesUiCapabilitie in register_pdf_png_reporting.tsx is true <img width="1458" alt="Screenshot 2023-08-14 at 12 34 38 PM" src="https://github.com/elastic/kibana/assets/20343860/f6b567fa-3fbd-4039-aa64-fd28bb4534fb"> ## After <img width="1343" alt="Screenshot 2023-08-14 at 2 18 30 PM" src="https://github.com/elastic/kibana/assets/20343860/1e4ade9e-332c-4431-954a-38e8a16d4131"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…163873) ## Summary This PR fixes a bug mentioned in elastic/sdh-kibana#4016 from #153429 where users with custom roles should allow them the ability to generate reports (with `xpack.reporting.roles.enabled: false`) in Dashboard. This bug doesn't arise for users with all privileges. - set xpack.reporting.roles.enabled false in the kibana.yml - load sample data - create a custom role where the index (whatever sample data index you want) has the read and view_index_metadata privilege. - Add the Kibana privilege for all spaces Analytics > Dashboard > Generate PDF or PNG Reports and Download Csv reports from Saved Search panels. Create the global privilege and then the role. - Apply that role to a new user and log in using that user. ## Before You can see in the console that usesUiCapabilitie in register_pdf_png_reporting.tsx is true <img width="1458" alt="Screenshot 2023-08-14 at 12 34 38 PM" src="https://github.com/elastic/kibana/assets/20343860/f6b567fa-3fbd-4039-aa64-fd28bb4534fb"> ## After <img width="1343" alt="Screenshot 2023-08-14 at 2 18 30 PM" src="https://github.com/elastic/kibana/assets/20343860/1e4ade9e-332c-4431-954a-38e8a16d4131"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

dej611 added 2 commits March 22, 2023 11:22

✨ Enable reporting sharing for Lens

76b5ebc

✨ Extends reporting to support lens_visualization

7fbac81

dej611 added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.8.0 labels Mar 22, 2023

dej611 commented Mar 22, 2023

View reviewed changes

dej611 added 2 commits March 22, 2023 15:13

♻️ Migrate objectType to "lens"

7b49555

♻️ Minor refactors

dc40345

dej611 commented Mar 22, 2023

View reviewed changes

dej611 and others added 6 commits March 23, 2023 12:11

🐛 Fix bug when shareURL priviliges are not granted

f408271

♻️ Add priviledges check

ef9246e

✅ Add functional tests

9c21584

Merge branch 'main' into feature/130438

4d885eb

📸 Update snapshots

b9f06e7

Merge branch 'feature/130438' of github.com:dej611/kibana into featur…

b1e0f7c

…e/130438

dej611 marked this pull request as ready for review March 23, 2023 16:31

dej611 requested review from a team as code owners March 23, 2023 16:32

Merge branch 'main' into feature/130438

f638c8f

stratoula reviewed Mar 24, 2023

View reviewed changes

dej611 added 2 commits March 24, 2023 15:20

♻️ Move from unsaved to timestamped title

7422a61

Merge branch 'feature/130438' of github.com:dej611/kibana into featur…

429d5f5

…e/130438

🐛 Fix i18n id

a359e4b

Merge branch 'feature/130438' of github.com:dej611/kibana into featur…

39dcb2e

…e/130438

tsullivan requested changes Apr 3, 2023

View reviewed changes

dej611 added 2 commits April 4, 2023 10:18

Merge remote-tracking branch 'upstream/main' into feature/130438

23286a3

🐛 Fix reporting for dirty state

fe0d606

tsullivan approved these changes Apr 6, 2023

View reviewed changes

tsullivan reviewed Apr 6, 2023

View reviewed changes

Merge branch 'main' into feature/130438

a414421

stratoula mentioned this pull request Apr 10, 2023

[Lens] Console error when opening Lens with a (short) share URL #153679

Closed

dej611 merged commit 41170fe into elastic:main Apr 12, 2023

kibanamachine added the backport:skip This commit does not require backporting label Apr 12, 2023

dej611 mentioned this pull request Apr 13, 2023

[Lens] Improve reporting image size for each visualization type #154894

Closed

Dosant mentioned this pull request Apr 17, 2023

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/group3/lens_reporting·ts - lens app - group 3 lens reporting PDF report should enable curl reporting if the visualization is saved #154957

Closed

KOTungseth mentioned this pull request Apr 25, 2023

[DOCS] Add documentation for 8.8 #155793

Closed

19 tasks

KOTungseth mentioned this pull request May 9, 2023

[DOCS] Adds 8.8 Viz docs #157215

Merged

This was referenced Aug 14, 2023

[Fix] add to clause to allow read only users the image reporting share menu #163855

Closed

[Reporting] Allow custom roles to use image reporting in dashboard #163873

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lens] Enable report sharing #153429

[Lens] Enable report sharing #153429

dej611 commented Mar 22, 2023 •

edited

Loading

dej611 Mar 22, 2023

tsullivan Mar 27, 2023

tsullivan Mar 27, 2023

dej611 Mar 22, 2023

elasticmachine commented Mar 23, 2023

stratoula left a comment

stratoula Mar 24, 2023

dej611 Mar 24, 2023

stratoula commented Mar 24, 2023

dej611 commented Mar 24, 2023

stratoula commented Mar 24, 2023

dej611 commented Mar 24, 2023

dej611 commented Mar 31, 2023

tsullivan left a comment

dej611 commented Apr 4, 2023

tsullivan left a comment

tsullivan commented Apr 6, 2023 •

edited

Loading

tsullivan Apr 6, 2023

kibana-ci commented Apr 10, 2023

ESLint disabled line counts

Total ESLint disabled count

[Lens] Enable report sharing #153429

[Lens] Enable report sharing #153429

Conversation

dej611 commented Mar 22, 2023 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

dej611 Mar 22, 2023

Choose a reason for hiding this comment

tsullivan Mar 27, 2023

Choose a reason for hiding this comment

tsullivan Mar 27, 2023

Choose a reason for hiding this comment

dej611 Mar 22, 2023

Choose a reason for hiding this comment

elasticmachine commented Mar 23, 2023

stratoula left a comment

Choose a reason for hiding this comment

stratoula Mar 24, 2023

Choose a reason for hiding this comment

dej611 Mar 24, 2023

Choose a reason for hiding this comment

stratoula commented Mar 24, 2023

dej611 commented Mar 24, 2023

stratoula commented Mar 24, 2023

dej611 commented Mar 24, 2023

dej611 commented Mar 31, 2023

tsullivan left a comment

Choose a reason for hiding this comment

dej611 commented Apr 4, 2023

tsullivan left a comment

Choose a reason for hiding this comment

tsullivan commented Apr 6, 2023 • edited Loading

tsullivan Apr 6, 2023

Choose a reason for hiding this comment

kibana-ci commented Apr 10, 2023

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

dej611 commented Mar 22, 2023 •

edited

Loading

tsullivan commented Apr 6, 2023 •

edited

Loading